test: the exactly-once test keeps its leases on a slow CI machine - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestConcurrentClientsFinalizeExactlyOncefailed once on the Postgres 17 job of the 0.2.0 release PR's CI run: 10 of 2,000 jobs ran twice and history showed 7 distinct clients instead of 4. That is three clients losing their two-second test lease on a loaded runner, being fenced, and having their running jobs rescued and re-run elsewhere: at-least-once under lease loss, exactly as designed, but not what this test is about.The test now starts its four clients with a one-minute lease (renewed every five seconds) through a new
startedWithharness helper, so its outcome depends on the finalize path alone. The fencing tests keep the short lease they need. Passes locally three times in a row with-race; the rerun of the failed job also passed, as expected of a timing flake.