ci: release-please manages one package; the workflow tags the sub-modules - #24
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first real release PR (#23, 0.1.2) touches only the root module: with three packages and
linked-versions, release-please only proposes a release for a package that has commits under its own path, and #22 changed nothing underhopperotel/orhopperui/. The plugin keeps versions in sync among the packages it releases; it does not add the others. So the sub-modules would have stayed at v0.1.1 and the one-version promise indocs/releasing.mdwould have been broken on the very first automated release.This makes release-please manage one package, the core module, with the sub-modules'
go.modrequirement rewritten throughextra-files(the// x-release-please-versionlines), and has the release workflow taghopperotel/vX.Y.Zandhopperui/vX.Y.Zon the release commit before goreleaser runs. One changelog, one GitHub release, three tags at one version, from any change anywhere in the repository. The manifest drops the sub-module entries.Merge this before #23. release-please re-evaluates on the next push to
canaryand rewrites #23 under the new configuration (it should then also carry the twogo.modbumps).docs/releasing.mdis updated; actionlint passes.