feat(problem): a problem missing a param its message needs is sent as its status's problem - #10
Merged
Merged
Conversation
… its status's problem
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A type can declare
Paramsits localized message uses, but nothing made a handler pass them. Without one, a client formatting the message gets use-intl's fallback, the raw key (apiErrors.name_taken), instead of a sentence.Now the problem itself guarantees it:
Type.NewandAt/AtParameterremember the type's declared params.Problem.MarshalJSONsends a problem missing one as the about:blank problem for its status (keeping status, detail and instance).FieldError.MarshalJSONsends a field error missing one as theinvalidrule, keeping its location. This coversproblem.Write, huma's serializer, and anything else that encodes a problem.(*Problem).Resolve()returns a problem as it will be sent, for callers that build another representation from it (core's legacy error envelope).Testing
make checkTestMissingParamIsSentAsStatusProblemandTestFieldMissingParamIsSentAsInvaliddecode the sent JSON with and without the param.Checklist
make checkpassespackages/problem/src/messages/(none changed)