Repository navigation
New slides end with self.wait(0.1) so Play can build them - #6
Merged
Merged
Conversation
A slide made with New Slide ended its construct() with `pass`. Once text
was typed into its placeholders, `pass` was removed, leaving a slide with
no animation, which manim-slides refuses to build ("You have to play at
least one animation ... before pausing"), so Play failed on it.
New slides now end with `self.wait(0.1) # manimble new slide`, as new
builds already do. It keeps the placeholder comments inside the class,
as `pass` did, and is never removed. Slides made earlier keep their
`pass` handling.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Play fails with "building slide N failed" on any slide made with New Slide that has no animation. The build log shows manim-slides refusing it:
A new slide's
construct()ended inpass. Once text was typed into its placeholders,passwas removed and onlyself.add(...)calls were left, with no animation.Fix
_layout_bodynow ends a new slide withself.wait(0.1) # manimble new slideinstead ofpass. New builds already do the same thing (new_buildaddsself.wait(0.1) # manimble new buildfor the same reason). Likepass, the statement keeps the# manimble placeholdercomments inside the class. Unlikepass, it is never removed. Slides made before this change keep theirpasshandling, and the comment there now says so.Testing
engine/manimble/core.pycompiles.self.wait(0.1)) builds withmanim_slides render: "Played 1 animations", andslides/NewSlide1.jsonis written.self.add(...)) builds onceself.wait(0.1)is appended.tests/has no coverage of new slides.🤖 Generated with Claude Code