Repository navigation
feat: optional session saving with :PiToggleSession - #28
Merged
Merged
Conversation
Owner
|
fixes #21 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pi.nvim always runs pi with
--no-session, so requests from:PiAsk/:PiAskSelectioncannot be revisited later withpi --resume. This PR makes session saving opt-in.sessionconfig option (defaultfalse, so existing behavior is unchanged). Whentrue,--no-sessionis omitted and pi persists each request as a session.:PiToggleSessioncommand to flip the option at runtime (notifies the new state). Applies to the next request.Note: each request still creates its own session; this does not chain requests into one conversation (
--continue).Tests
Added tests for
session = true, invalidsessionvalues, and:PiToggleSessiontoggling both ways.make test: 42/42 passing.