Conversation
cheb0
added this pull request to stack #515
October 2, 2026 11:01
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0-materialized-column-field-iter #559 +/- ##
====================================================================
+ Coverage 77.03% 77.10% +0.06%
====================================================================
Files 251 251
Lines 19104 19162 +58
====================================================================
+ Hits 14716 14774 +58
Misses 4388 4388 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
eguguchkin
requested review from
eguguchkin and
forshev
and removed request for
forshev
October 5, 2026 10:28
dkharms
self-requested a review
October 5, 2026 10:38
eguguchkin
removed their request for review
October 5, 2026 10:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aggregatornow accepts batches of lids,SourceNodeIteratorrerturns a batch of sourcesSingleSourceCountAggregatornow delegates aggregation logic tosourceCounterinterface, which has two implementations:plainSourceCounterhandles ordinary aggs, uses a chunked array for counting.tsSourceCounterhandles timeseries aggs, uses mapArray is better than map when we have many many lids processed in agg, but can be slower when the number of lids is low and agg is high cardinality (we need to allocate an array). This is partially handled by "chunking" the array.
If you have used LLM/AI assistance please provide model name and full prompt:
Stack created with GitHub Stacks CLI • Give Feedback 💬