Skip to content

fix: [stable-8.0.10][OCISDEV-1675] fix a nil pointer panic in the sha… - #818

Draft
2403905 wants to merge 1 commit into
stable-8.0from
stable-8.0.10-fix
Draft

2403905 wants to merge 1 commit into
stable-8.0from
stable-8.0.10-fix

Conversation

@2403905

@2403905 2403905 commented Nov 16, 2026

Copy link
Copy Markdown

…recache Remove (#814)

  • fix: [stable-8.0.10][OCISDEV-1675] fix a nil pointer panic in the sharecache Remove

sharecache.Cache.Remove read us.UserShares[ssid].IDs with no nil check. When the user had no entry for the space of the share, Remove panicked. A share ID without a delimiter caused the same panic. The panic occurred in an errgroup goroutine and stopped the process.

Remove now skips the delete when the space entry is absent. It still persists the cache, so a stale cache gets an etag conflict, a resync and a retry.

  • fix: [stable-8.0.10][OCISDEV-1675] fix nil checks in the providercache

PurgeSpace stored &Shares{} with a nil Shares map. A later Add to the same space panicked with "assignment to entry in nil map". PurgeSpace now stores an empty map.

Remove discarded the ok value of spaces.Spaces.Load and checked the ok value of Providers.Load again. Remove now checks the correct value.


…recache Remove (#814)

* fix: [stable-8.0.10][OCISDEV-1675] fix a nil pointer panic in the sharecache Remove

sharecache.Cache.Remove read us.UserShares[ssid].IDs with no nil check.
When the user had no entry for the space of the share, Remove panicked.
A share ID without a delimiter caused the same panic. The panic occurred
in an errgroup goroutine and stopped the process.

Remove now skips the delete when the space entry is absent. It still
persists the cache, so a stale cache gets an etag conflict, a resync
and a retry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix: [stable-8.0.10][OCISDEV-1675] fix nil checks in the providercache

PurgeSpace stored &Shares{} with a nil Shares map. A later Add to the
same space panicked with "assignment to entry in nil map". PurgeSpace
now stores an empty map.

Remove discarded the ok value of spaces.Spaces.Load and checked the ok
value of Providers.Load again. Remove now checks the correct value.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@kw-security

kw-security commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants