Repository navigation
Conversation
…recache Remove (#814) * fix: [stable-8.0.10][OCISDEV-1675] fix a nil pointer panic in the sharecache Remove sharecache.Cache.Remove read us.UserShares[ssid].IDs with no nil check. When the user had no entry for the space of the share, Remove panicked. A share ID without a delimiter caused the same panic. The panic occurred in an errgroup goroutine and stopped the process. Remove now skips the delete when the space entry is absent. It still persists the cache, so a stale cache gets an etag conflict, a resync and a retry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: [stable-8.0.10][OCISDEV-1675] fix nil checks in the providercache PurgeSpace stored &Shares{} with a nil Shares map. A later Add to the same space panicked with "assignment to entry in nil map". PurgeSpace now stores an empty map. Remove discarded the ok value of spaces.Spaces.Load and checked the ok value of Providers.Load again. Remove now checks the correct value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…recache Remove (#814)
sharecache.Cache.Remove read us.UserShares[ssid].IDs with no nil check. When the user had no entry for the space of the share, Remove panicked. A share ID without a delimiter caused the same panic. The panic occurred in an errgroup goroutine and stopped the process.
Remove now skips the delete when the space entry is absent. It still persists the cache, so a stale cache gets an etag conflict, a resync and a retry.
PurgeSpace stored &Shares{} with a nil Shares map. A later Add to the same space panicked with "assignment to entry in nil map". PurgeSpace now stores an empty map.
Remove discarded the ok value of spaces.Spaces.Load and checked the ok value of Providers.Load again. Remove now checks the correct value.