Skip to content

fix: [OCISDEV-1674] allow viewers to print and copy - #13525

Merged
LarsJurgensen merged 2 commits into
masterfrom
fix/OCISDEV-1674-viewer-print-copy
Nov 18, 2026
Merged

LarsJurgensen merged 2 commits into
masterfrom
fix/OCISDEV-1674-viewer-print-copy

Conversation

@LarsJurgensen

Copy link
Copy Markdown
Contributor

Description

Two small fixes for users with the "Can view" role.

1. Copy in Shared with me

The Copy action was missing in the Shared with me list. Now it shows
there when the user may download.

2. Print in office apps

oCIS has two viewer roles:

  • Can view: may download
  • Secure viewer: may not download

CS3 has two matching open modes:

  • read: may download, print allowed
  • view: secure view, print, copy and export turned off

Web and public links sent every read-only user to view. So normal
viewers lost print, copy and export in OnlyOffice and Collabora.

User Download Before After
Can view yes view read
Public view link yes view read (reva, see below)
Secure viewer no view view
Can edit yes write write

The public link part is in reva: owncloud/reva#819. It arrives with the
next reva bump.

Related Issue

  • Related to OCISDEV-1674

How Has This Been Tested?

  • local macOS, oCIS from source, OnlyOffice 9.3 in Docker
  • "Can view" user share: Print available, CheckFileInfo shows DisablePrint: false
  • public view link (with reva change): Print available
  • editor: opens in edit mode, unchanged
  • Shared with me: Copy shown, paste into Personal works
  • unit tests: web-app-external view mode, useFileActionsCopy

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised: n/a

Copy was hidden in the Shared with me list, so a file shared on its
own could not be copied. Show it there when the user may download.

Signed-off-by: Lars Jürgensen <lars.jurgensen@kiteworks.com>
Viewers who may download opened office files in view mode, which is
meant for secure viewers and turns off print, copy and export. Open
them in read mode instead.

Signed-off-by: Lars Jürgensen <lars.jurgensen@kiteworks.com>
@LarsJurgensen
LarsJurgensen requested a review from a team as a code owner November 18, 2026 14:59
@LarsJurgensen LarsJurgensen self-assigned this Nov 18, 2026
@kw-security

kw-security commented Nov 18, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@LarsJurgensen
LarsJurgensen merged commit 37a8944 into master Nov 18, 2026
87 checks passed
@LarsJurgensen
LarsJurgensen deleted the fix/OCISDEV-1674-viewer-print-copy branch November 18, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants