Repository navigation
fix: [OCISDEV-1674] allow viewers to print and copy - #13525
Merged
Merged
Conversation
Copy was hidden in the Shared with me list, so a file shared on its own could not be copied. Show it there when the user may download. Signed-off-by: Lars Jürgensen <lars.jurgensen@kiteworks.com>
Viewers who may download opened office files in view mode, which is meant for secure viewers and turns off print, copy and export. Open them in read mode instead. Signed-off-by: Lars Jürgensen <lars.jurgensen@kiteworks.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
deyankiteworks
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two small fixes for users with the "Can view" role.
1. Copy in Shared with me
The Copy action was missing in the Shared with me list. Now it shows
there when the user may download.
2. Print in office apps
oCIS has two viewer roles:
CS3 has two matching open modes:
Web and public links sent every read-only user to
view. So normalviewers lost print, copy and export in OnlyOffice and Collabora.
The public link part is in reva: owncloud/reva#819. It arrives with the
next reva bump.
Related Issue
How Has This Been Tested?
DisablePrint: falseweb-app-externalview mode,useFileActionsCopyTypes of changes
Checklist: