Skip to content

fix(ci): disable async uploads in litmus runner to prevent 425 Too Early - #13519

Merged
mmattel merged 2 commits into
masterfrom
fix/litmus-disable-async-uploads
Nov 18, 2026
Merged

mmattel merged 2 commits into
masterfrom
fix/litmus-disable-async-uploads

Conversation

@mmattel

@mmattel mmattel commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Summary

The litmus basic suite's put_get test PUTs a file and immediately GETs it in the same request sequence. When OCIS_ASYNC_UPLOADS=true is set in the CI environment (which it is by default), oCIS returns HTTP 425 Too Early on that GET because the async post-processing pipeline has not yet committed the file. The litmus Docker container has no retry logic for 425, so the test fails spuriously.

This was observed as a one-of-16 failure in the spaces-endpoint litmus run on the stable-9.0 CI flakiness backport PR #13517.

Root cause

run-litmus.py builds its server environment via {**os.environ}, which inherits OCIS_ASYNC_UPLOADS=true from the CI runner. The base_server_env() function did not override it, so async uploads stayed enabled throughout the litmus run.

Fix

Explicitly set OCIS_ASYNC_UPLOADS=false in base_server_env(). Litmus is a synchronous WebDAV compliance suite — it has no concept of async upload semantics and must be able to read back a file immediately after writing it.

Test plan

  • Litmus CI job passes consistently on this PR
  • No regression in other litmus endpoints (old-endpoint, new-endpoint, new-shared, old-shared)

🤖 Generated with Claude Code

The litmus basic suite's put_get test PUTs a file then immediately GETs
it. When OCIS_ASYNC_UPLOADS is true (the CI default), oCIS returns
425 Too Early on the GET because post-processing has not completed yet.
Litmus has no retry logic for 425, so the test fails spuriously.

Explicitly set OCIS_ASYNC_UPLOADS=false in the litmus server environment
so it cannot be inherited from the ambient CI env. Litmus is a
synchronous WebDAV compliance suite and has no use for async upload
semantics.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Signed-off-by: Martin Mattel <github@diemattels.at>
@mmattel
mmattel requested a review from a team as a code owner November 18, 2026 10:03
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Signed-off-by: Martin Mattel <github@diemattels.at>
@kw-security

kw-security commented Nov 18, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mmattel
mmattel enabled auto-merge (squash) November 18, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants