Repository navigation
fix(ci): disable async uploads in litmus runner to prevent 425 Too Early - #13519
Merged
Merged
Conversation
The litmus basic suite's put_get test PUTs a file then immediately GETs it. When OCIS_ASYNC_UPLOADS is true (the CI default), oCIS returns 425 Too Early on the GET because post-processing has not completed yet. Litmus has no retry logic for 425, so the test fails spuriously. Explicitly set OCIS_ASYNC_UPLOADS=false in the litmus server environment so it cannot be inherited from the ambient CI env. Litmus is a synchronous WebDAV compliance suite and has no use for async upload semantics. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Martin Mattel <github@diemattels.at>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Martin Mattel <github@diemattels.at>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
mmattel
enabled auto-merge (squash)
November 18, 2026 10:06
deyankiteworks
approved these changes
Nov 18, 2026
This was referenced Nov 18, 2026
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The litmus
basicsuite'sput_gettest PUTs a file and immediately GETs it in the same request sequence. WhenOCIS_ASYNC_UPLOADS=trueis set in the CI environment (which it is by default), oCIS returns HTTP 425 Too Early on that GET because the async post-processing pipeline has not yet committed the file. The litmus Docker container has no retry logic for 425, so the test fails spuriously.This was observed as a one-of-16 failure in the
spaces-endpointlitmus run on the stable-9.0 CI flakiness backport PR #13517.Root cause
run-litmus.pybuilds its server environment via{**os.environ}, which inheritsOCIS_ASYNC_UPLOADS=truefrom the CI runner. Thebase_server_env()function did not override it, so async uploads stayed enabled throughout the litmus run.Fix
Explicitly set
OCIS_ASYNC_UPLOADS=falseinbase_server_env(). Litmus is a synchronous WebDAV compliance suite — it has no concept of async upload semantics and must be able to read back a file immediately after writing it.Test plan
old-endpoint,new-endpoint,new-shared,old-shared)🤖 Generated with Claude Code