Repository navigation
Conversation
…ic in the sharecache Remove Bump reva to the head of owncloud/reva#814. The reva fix adds a nil check in sharecache.Cache.Remove. Without it, a removal of a share in a space that the user has no cache entry for stops the process. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
… providercache Bump reva to the head of owncloud/reva#814. The new reva commit fixes a nil map in providercache.Cache.PurgeSpace and a wrong ok check in providercache.Cache.Remove. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s before it serves Bump reva to the head of owncloud/reva#814. The new reva commit lets Stop and GracefulStop of pkg/rgrpc work before the grpc server exists. Before, a SIGTERM during a slow service start crashed the sharing service with a nil pointer panic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ncloud/reva#814 owncloud/reva#814 is merged as d74730112. Point reva to that commit. The merge does not contain the rgrpc stop-before-start fix. That fix is in owncloud/reva#815. Thus this commit also removes the vendored rgrpc change and its changelog entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request bumps reva to
d74730112. This is the merge commit of owncloud/reva#814.sharecache.Cache.Removein reva (pkg/share/manager/jsoncs3/sharecache/sharecache.go) read the share IDs of a space with no nil check. When the user had no cache entry for the space of the share,Removepanicked. The panic occurred in an errgroup goroutine, so it stopped the process. The panic occurred on school-0255 and school-0265 during the cleanup of orphaned shares (OCSRE-2548).Unshareand all other removal paths were affected too.The reva fix skips the delete when the space entry is absent. It still persists the cache, so a stale cache gets an etag conflict, a resync and a retry.
The reva pull request also fixes two related nil checks in
pkg/share/manager/jsoncs3/providercache/providercache.go:PurgeSpacestored a nil share map. A laterAddto the same space panicked.Removechecked the wrongokvalue after it loaded the space.Changes
go.mod,go.sum,vendor/modules.txt: revabb724be57312→d74730112e09.vendor/github.com/owncloud/reva/v2/pkg/share/manager/jsoncs3/sharecache/sharecache.go: the nil check inRemove.vendor/github.com/owncloud/reva/v2/pkg/share/manager/jsoncs3/providercache/providercache.go: the fixes inPurgeSpaceandRemove.changelog/unreleased/fix-sharecache-remove-nil-panic.md: the changelog entry.Not in this pull request
The fix for the
pkg/rgrpcpanic when a grpc server stops before it serves is in owncloud/reva#815. When owncloud/reva#815 is merged, a separate ocis pull request must bump reva.Tests
pkg/share/manager/jsoncs3/...packages pass with-race.go build -mod=vendorpasses for./ocis/cmd/ocis/,./services/sharing/...,./services/storage-shares/...and./services/gateway/....Related
stable-8.0version of the fix: fix: [stable-8.0][OCISDEV-1685] remove stale group shares in the share manager #13460🤖 Generated with Claude Code