Skip to content

fix(mobile): Android push notifications via Firebase - #57

Merged
KMKoushik merged 1 commit into
mainfrom
fix/android-push-firebase
Nov 16, 2026
Merged

KMKoushik merged 1 commit into
mainfrom
fix/android-push-firebase

Conversation

@KMKoushik

Copy link
Copy Markdown
Contributor

Configure Android Firebase through an EAS secret file variable, add the notification icon, and allow push testing on Google Play-enabled Android emulators. No server changes or credentials committed.

Mobile typecheck, lint, and 67 tests pass. Building versionCode 4 for Play internal testing only; end-to-end push verification follows.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 294a44d2-2745-4af3-91a3-41d1d6f5fe50
Commits

Reviewing files that changed from the base of the PR and between 488953f and 40514e1.

Files ignored due to path filters: 1

  • mobile/assets/notification-icon.png is excluded by !**/*.png
Files selected for processing: 5

  • mobile/.gitignore
  • mobile/RELEASING.md
  • mobile/app.config.ts
  • mobile/src/lib/appConfig.test.ts
  • mobile/src/lib/push.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@KMKoushik

Copy link
Copy Markdown
Contributor Author

Android token creation reaches expo-notifications' native PushTokenModule, which rejects with REGISTRATION_FAIL_CODE when FirebaseMessaging.getInstance() cannot initialize and explicitly points to missing googleServicesFile. The existing channel is created before permission and token requests, so no permission-flow rewrite is needed.

EAS confirms FCM V1 is configured for app.splitpro and GOOGLE_SERVICES_JSON is secret in production + preview. VersionCode 4 build: https://expo.dev/accounts/koushikdotdev/projects/splitpro/builds/f7951eb8-e38e-4b44-b5bd-2ca5474e480f . This build will go to internal only; closed testing will remain on versionCode 3.

@KMKoushik
KMKoushik merged commit bb4837b into main Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant