Repository navigation
fix: let the App Store review account finish account deletion - #56
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App Review signs in with the demo account (REVIEW_LOGIN_EMAIL / REVIEW_LOGIN_CODE) but can't finish account deletion, because the deletion code is emailed to an inbox they can't see.
For that one account, requesting a deletion code now stores REVIEW_LOGIN_CODE instead of a random code and sends no email, the same way sign-in does. The goodbye email is skipped too. Everything else stays the same: a code still has to be requested first, and the expiry, attempt limits and constant-time check all apply. Other accounts are unaffected.
Deleting the account clears its email, so the reviewer's next sign-in creates a fresh account.
Tests: added an integration test covering these cases. The review code is rejected for a normal account, and that account still needs its emailed code. The review code is rejected before a code is requested. The review account is deleted with the review code and no email is sent. The reviewer can sign in again afterwards as a new account.
Summary by CodeRabbit