Repository navigation
fix(docker): pin node:22.23.5-alpine - #54
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker/Dockerfilewas on Node 20 (EOL), onnode:20.11.1-alpineandnode:20-alpine3.19. This pins both stages tonode:22.23.5-alpine(the Nov 11 security release) and installs with--frozen-lockfileusingpnpm@8.9.2, the version inpackageManager.It also fixes three bugs that were already on main. As it stood, the image couldn't build or migrate:
pnpm installran before the schema was copied in, sopostinstall(prisma generate) failed. The schema is now copied first.openssl-1.1.x.opensslis now installed.start.shranpnpx prisma, which downloads the latest Prisma from npm. That version refusesmigrate deploy, and becausestart.shdoesn't stop on errors, the server started on an empty schema. The release stage now installs the lockedprisma@5.22.0CLI, andstart.shusesset -e.Railway doesn't use this Dockerfile (the service builds with Nixpacks/Railpack), and no workflow builds or publishes it. Only
docker/build.shuses it, run by hand.Verified locally (arm64): the build passes. Against an empty Postgres, all 18 migrations apply,
/api/healthzand/auth/signinreturn 200, and the image runsnode -v= v22.23.5 and Prisma 5.22.0 onlinux-musl-arm64-openssl-3.0.x.