Repository navigation
fix: the CLA status stays failing when the record write fails - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decideStatus, plusevaluate, which drives read, find and record the way the workflow does. Both sit between the matcher markers.CLAturnssuccessonly when the person is exempt, is already in the record, or the write tocla-signatureshas just succeeded.CLA.mdbefore the write) now setsfailurewith "Could not record your agreement. Comment /orbynAgree again to try again.", updates the one bot comment with that line, and fails the run.error"Could not check the agreement record." and fails the run./orbynAgreecomment, or any later event, tries again from the start.Not in this PR
Testing
node --test scripts/*.test.mjs: 37 passing (13 new). They cover exempt, already signed, unsigned, agreement with a successful write, agreement with a rejected write (409 exhausted, 500, 403), a read error, and a second attempt after a failure that records normally. One test checks every input combination and fails ifsuccessis returned without exempt, signed, or a successful write.node --checkpasses on the embedded script.AI usage