Add the refresh tokens relationship to the account protocols - #1307
Conversation
Infrahub declares a `refresh_tokens` relationship on CoreGenericAccount, so that the delete of an account also removes its refresh tokens. This file is generated from that schema, so it needs the same relationship. Rendered with `invoke backend.generate` in the Infrahub repository. Do not edit it by hand.
The account now declares a `refresh_tokens` relationship, and the SDK protocols are generated from that schema. Without this bump, `invoke backend.validate-generated` stays red. The pinned commit is the head of opsmill/infrahub-sdk-python#1307. It has to move to the squashed commit once that PR merges.
Deploying infrahub-sdk-python with
|
| Latest commit: |
95e5a26
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b390a78c.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://chore-add-account-refresh-to.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## stable #1307 +/- ##
=======================================
Coverage 84.23% 84.24%
=======================================
Files 147 147
Lines 13045 13047 +2
Branches 1930 1930
=======================================
+ Hits 10989 10991 +2
Misses 1493 1493
Partials 563 563
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
f797f5c to
95e5a26
Compare
The account now declares a `refresh_tokens` relationship, and the SDK protocols are generated from that schema. Without this bump, `invoke backend.validate-generated` stays red. The pinned commit is the head of opsmill/infrahub-sdk-python#1307. It has to move to the squashed commit once that PR merges.
ogenstad
left a comment
ogenstad
left a comment
There was a problem hiding this comment.
Sanity check for this one. These are in the Internal namespace. I don't think they are exposed through the GraphQL API?
Are we sure this is needed?
I guess we have a code generator bug for Python SDK protocols then, because we have internal stuff in there already (even though we do not expose them over the graphql API). |
External identities are also exposed in the SDK and they also belong to the Internal namespace |
ogenstad
left a comment
ogenstad
left a comment
There was a problem hiding this comment.
Approving instead since this is just a temporary fix to resolve a CI validation issue and no consumers will attempt to use these. The target will then be to avoid these to be generated within the 1.12.0 cycle for Infrahub.
The account now declares a `refresh_tokens` relationship, and the SDK protocols are generated from that schema. Without this bump, `invoke backend.validate-generated` stays red. The pinned commit is the head of opsmill/infrahub-sdk-python#1307. It has to move to the squashed commit once that PR merges.
3 participants
Why
Infrahub declares a
refresh_tokensrelationship onCoreGenericAccount, so thatthe delete of an account also removes its refresh tokens. This file is generated
from that schema, so it has to carry the same relationship. Without it,
invoke backend.generatein the Infrahub repository leaves this file dirty and thevalidate-generatedjob stays red.Needed by opsmill/infrahub#10435, which fixes opsmill/infrahub#10304.
What changed
refresh_tokensis added toCoreGenericAccountandCoreGenericAccountSync.Nothing else. The file is rendered by
invoke backend.generatein the Infrahubrepository, not written by hand.
How to review
One commit on top of
stable, two lines. The Infrahub submodule already pins thestablehead, so the pointer bump on that side moves by this commit alone.