Repository navigation
Add sine tone fallback for tracks without a singer - #2568
Open
emeraldsingers wants to merge 2 commits into
Open
emeraldsingers wants to merge 2 commits into
emeraldsingers wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks with no singer, or with a singer that is missing or not loaded, are currently silent. This adds a built-in sine renderer so such tracks play a tone that follows the notes and pitch curve.
SineRendereris used automatically when a track has no usable singer. It follows the pitch curve and supportsDYNandPITD.PhraseSource/RenderPhrase). A track without a singer now builds phrases from its notes, and the fallback skips expression graph processing.SINE.SINEonly while the fallback is active. It is removed as soon as a real singer is assigned.