Repository navigation
DiffSinger: match word duration rounding and tail SP grouping to training data - #2565
Open
KakaruHayate wants to merge 1 commit into
Open
KakaruHayate wants to merge 1 commit into
KakaruHayate wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small consistency fixes for the word-level duration/word-division inputs used by DiffSinger variance/pitch models:
ound(cumsum(ms) / frame + 0.5) and derives the word budget from that, so the old per-endpoint truncation was off by one frame at boundaries (e.g. 100 ms notes at 11.609977 ms/frame: 8/9 vs 9/9). It now uses DiffSingerUtils.DurationsMsToFrames over the intervals.
Impact
Verification
No changes to the .ds variance clamp (will be a follow-up PR), and this branch is based on upstream master, not on the #2388 revert PR.