Skip to content

Fix focus ring clipping and match variant coloring - #3536

Merged
MartinaeyNL merged 2 commits into
mainfrom
fix/focus-ring-clipping
Nov 2, 2026
Merged

MartinaeyNL merged 2 commits into
mainfrom
fix/focus-ring-clipping

Conversation

@Ekhorn

@Ekhorn Ekhorn commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Description

Focus rings on fields and menu bar buttons were cut off by parents that scroll or hide overflow, such as dialog content and the header menu, because Lumo draws them outside the element. Error and contrast buttons also showed the green primary ring.

Changelog

  • Draw the focus ring inside fields, since our theme removes the padding Lumo reserves for it
  • Draw the focus ring inside menu bar buttons, which the menu bar clips at its edges
  • Use the error color for the focus ring of error buttons and the contrast color for contrast buttons

Checklist

  • 1. Acceptance criteria of the linked issue(s) are met
  • 2. Tests are written and all tests pass
  • 3. Changes are manually tested by you and the reviewer
  • 4. Documentation is written or updated

@Ekhorn
Ekhorn requested a review from MartinaeyNL November 2, 2026 14:52
@Ekhorn Ekhorn self-assigned this Nov 2, 2026
@Ekhorn

Ekhorn commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Does @remyberden have an opinion on this 😄 ?

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@MartinaeyNL MartinaeyNL added the Bug Error or issue in the system label Nov 2, 2026
@MartinaeyNL
MartinaeyNL added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit f912946 Nov 2, 2026
24 checks passed
@MartinaeyNL
MartinaeyNL deleted the fix/focus-ring-clipping branch November 2, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Error or issue in the system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants