Skip to content

test: add ReactiveOpenGaussTableManagementTest - #27

Closed
hezhangjian wants to merge 2 commits into
mainfrom
add-reactive-test
Closed

hezhangjian wants to merge 2 commits into
mainfrom
add-reactive-test

Conversation

@hezhangjian

Copy link
Copy Markdown
Member

No description provided.

@fu-turer
fu-turer force-pushed the add-reactive-test branch 4 times, most recently from f6a489e to df8973b Compare May 11, 2025 03:58
@hezhangjian
hezhangjian requested review from Copilot and fu-turer and removed request for fu-turer September 26, 2025 02:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new test class ReactiveOpenGaussTableManagementTest to test reactive OpenGauss table management functionality. The changes include Docker client updates, new test configuration, and improvements to the reactive OpenGauss implementation.

  • Updates Docker client configuration to use newer HTTP client implementation
  • Creates a comprehensive test suite for reactive OpenGauss table management operations
  • Refactors OpenGauss table management to remove unused dependencies

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
OpenGaussContainer.java Updates Docker client initialization to use DefaultDockerClientConfig and ApacheDockerHttpClient
table-facade-test-common/pom.xml Changes dependency from docker-java-api to docker-java-transport-httpclient5
ReactiveOpenGaussTestConfig.java Adds new test configuration for reactive OpenGauss testing with R2DBC setup
ReactiveOpenGaussTableManagementTest.java Implements comprehensive tests for table existence, creation, and deletion operations
ReactiveOpenGaussTableManagement.java Removes unused TableFacadeProperties.OpenGauss dependency
table-facade-spring-reactive-opengauss/pom.xml Adds PostgreSQL R2DBC dependencies and fixes logging exclusion
TableFacadeReactiveAutoConfiguration.java Updates constructor call to match refactored ReactiveOpenGaussTableManagement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

ConnectionFactoryOptions options = ConnectionFactoryOptions.builder()
.option(DRIVER, "postgresql")
.option(HOST, "localhost")
.option(PORT, 5432)

Copilot AI Sep 26, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded port 5432 should use the actual container port from openGaussContainer.getPort() to ensure tests work correctly when the container uses a different port.

Copilot uses AI. Check for mistakes.
Comment on lines +59 to +60
"localhost",
5432,

Copilot AI Sep 26, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded values should use openGaussContainer.getHost() and openGaussContainer.getPort() to ensure the R2DBC URL points to the correct container endpoint.

Copilot uses AI. Check for mistakes.
Comment on lines +40 to +52
private static OpenGaussContainer container;

@Autowired
private DatabaseClient databaseClient;

@Autowired
private ReactiveTableManagement tableManagement;

@AfterAll
void stopContainer() {
container.stopContainer();
}

Copilot AI Sep 26, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The container field is declared but never initialized or used. It should either be removed or properly initialized and used in the stopContainer() method.

Suggested change
private static OpenGaussContainer container;
@Autowired
private DatabaseClient databaseClient;
@Autowired
private ReactiveTableManagement tableManagement;
@AfterAll
void stopContainer() {
container.stopContainer();
}
@Autowired
private DatabaseClient databaseClient;
@Autowired
private ReactiveTableManagement tableManagement;

Copilot uses AI. Check for mistakes.
@hezhangjian
hezhangjian deleted the add-reactive-test branch April 18, 2026 07:53
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants