Skip to content

docs: make PR template guidance reader-first - #165

Merged
roboclaw-bot merged 2 commits into
mainfrom
openclaw/pr-template-rollout-libterminal
Nov 17, 2026
Merged

roboclaw-bot merged 2 commits into
mainfrom
openclaw/pr-template-rollout-libterminal

Conversation

@roboclaw-bot

Copy link
Copy Markdown
Contributor

Summary

Reviewers should understand the problem, task, or value of a terminal change before its implementation, and what validation established before a list of commands. Expand only the existing template's HTML comments with that ordering and paired, illustrative libterminal examples.

The original prompts, headings, checklists, compatibility/security guidance, and every byte outside HTML comments are unchanged. No new tests or contribution gates are introduced.

Compatibility And Security

No protocol, export, runtime, ordering, cancellation, or security behavior changes. This is PR-authoring guidance only; no dependency, toolchain, workflow execution, or release changes.

Validation

  • Preservation checks pass: all noncomment bytes match the original template, all three original prompts remain, comments are balanced, and the diff contains only .github/PULL_REQUEST_TEMPLATE.md. git diff --check passes.

  • Independent shared autoreview at P0–P3 is scoped-clean, with no actionable findings: python3 "$HOME/.agents/skills/autoreview/scripts/autoreview" --max-priority P3 --mode local with task-specific preservation context.

  • Formatting, build, portable/type checks, and lint pass. pnpm check then reports 184 passing and 9 failing tests: all failures are five-second timeouts in test/hub-close.test.ts native WebSocket teardown cases. A separate minimal native-WebSocket loopback probe errors before opening, without importing libterminal. This records a local validation limitation, not a green full check or a gate waiver.

  • Package checks pass separately via pnpm run pack:check; the original pnpm check stopped before that stage. Dependencies were installed with pnpm install --frozen-lockfile using declared pnpm 11.28.6; validation used Node 26.12.1. No lockfile or dependency changes.

  • Browser E2E/release checks were not run locally. Runtime source and tests are unchanged; hosted exact-head checks will be assessed before landing.

  • Tests added or updated when behavior changed

  • Browser, Node.js, and Worker impact considered

  • CHANGELOG.md updated when user-visible or compatibility-relevant

  • No credentials, private paths, private hosts, or sensitive logs included

The conditional test/changelog items are not applicable: this change affects only hidden PR-template guidance, not package behavior or compatibility.

Requested by and implemented with Hannes (@hannesrudolph).

Work sessions

Linked for team reference; these sessions aren’t public.

Worked on by

roboclaw-bot and others added 2 commits November 17, 2026 16:07
Co-authored-by: hannesrudolph <49103247+hannesrudolph@users.noreply.github.com>
Worked on by:
- @hannesrudolph

Co-authored-by: hannesrudolph <49103247+hannesrudolph@users.noreply.github.com>
OpenClaw-Publication: f2bcbc3e-5356-4e2a-86b7-bc19fb6f5075
@roboclaw-bot
roboclaw-bot requested a review from a team as a code owner November 17, 2026 16:08
@clawsweeper

clawsweeper Bot commented Nov 17, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@roboclaw-bot
roboclaw-bot merged commit a4655d5 into main Nov 17, 2026
13 checks passed
@roboclaw-bot
roboclaw-bot deleted the openclaw/pr-template-rollout-libterminal branch November 17, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant