Repository navigation
Fix VariableDatum getMarshalledSize() padding calculation - #40
Merged
Merged
Conversation
getMarshalledSize() used padding.length which is 0 before marshaling. The ByteBuffer marshal path then writes additional Align.to64bits() padding bytes, overflowing the pre-allocated buffer. Compute padding from the accumulated size instead, matching what Align.to64bits() will write. Fixes #36
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
padding.length(which is 0 before marshaling)Problem
getMarshalledSize()returned a size that didn't account for the padding bytes thatmarshal()writes viaAlign.to64bits(). When a ByteBuffer is allocated withgetMarshalledSize()bytes, marshaling overflows it.Example: 4-byte datum → getMarshalledSize() returned 12 (4+4+4+0) but marshal() wrote 16 (4+4+4+4 padding).
Test plan
VariableDatumTest.testMarshalUnmarshalByteBuffer()should passFixes #36