Repository navigation
Fix CI workflows for JDK 21 and headless javadoc build - #38
Merged
Merged
Conversation
CI was failing because the container used JDK 17 while javac.source=21. Also comment out the nbbrowse call in view.javadoc.local which is NetBeans-only and breaks headless CI builds during ant all. Closes #37
Contributor
|
I have updated property java.release from 17 to 21, and have also removed the nbbrowse dependency in build.xml |
Filenames diverged from class names due to SISO XML description casing changes on a case-insensitive filesystem. Fixes Linux CI compilation. See open-dis/opendis7-source-generator#25 for the root cause fix.
opentest4j-1.2.0.jar was only in run.test.classpath, not javac.test.classpath. NetBeans resolved it via libs.junit_5.classpath but that property is undefined in headless CI, causing PduTest.java to fail compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eclipse-temurin:17-jdktoeclipse-temurin:21-jdkin both workflows (project requiresjavac.source=21)nbbrowsecall inbuild.xmlview.javadoc.localtarget — it's NetBeans-only and breaks headless CI duringant alljava.releaseproperty from 17 to 21 to match project requirementsContext
All CI runs have been failing with
javac error: release version 21 not supportedbecause the container only had JDK 17. Once past compilation, the build would also fail on the uncommentednbbrowsetask during javadoc generation.The
publish.ymlworkflow for deploying Javadoc to GitHub Pages on release/on-demand is already correctly structured — these fixes unblock it.Closes #37
Test plan
Build and Testworkflow passes on this PRPublish Releasevia workflow_dispatch to confirm javadoc deploys to https://open-dis.github.io/opendis7-java/