Repository navigation
fix(dis7): restore EntityID alias and legacy flat field names - #91
Merged
Merged
Conversation
leif81
approved these changes
Oct 19, 2026
Member
|
Thank-you @ngjunsiang ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88 (see the issue for background).
EntityStatePdu.entityIDwas retyped from the flatEntityIDclass toEntityIdentifierin #2/#80, which broke pre-existing code with no compatibility path. This restores compatibility:EntityIDis an alias ofEntityIdentifiersiteID/applicationID/entityIDare read/write properties delegating tosimulationAddress.site/.application/entityNumberThe packet format is unchanged.
Also adds
tests/test_EntityID_compat.py(4 tests); full suite passes (19).