Repository navigation
fix(mail): render single newlines in draft bodies as line breaks - #33
Merged
Merged
Conversation
A markdown draft body used CommonMark soft breaks, so a two-line sign-off arrived as one line. Render with goldmark's hard-wraps option. Fixes #32
monit-reviewer
approved these changes
Sep 23, 2026
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: d18e7a0cb46e
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| go:implementation-tests | 0 |
Reviewer Coverage
go:implementation-tests— complete (broad); skipped: none; constraints: none
Inspected files (2)
internal/cmd/mail/draft.gointernal/cmd/mail/draft_test.go
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 42s | ~$0.83 (est.) | claude-sonnet-5 | cr 0.10.311
| Field | Value |
|---|---|
| Model | claude-sonnet-5 |
| Reviewers | go:implementation-tests |
| Engine | claude_cli · claude-sonnet-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 1m 42s wall · 1m 19s compute |
| Cost | ~$0.83 (est.) |
| Pricing basis | anthropic-public-2026-09-02 |
| Tokens | 26 in / 3.1k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5- In: 6
- Out: 1.0k
- Cache read: 104.5k
- Cache create: 74.4k
- Cost: ~$0.33 (est.)
- Duration: 23s
go:implementation-tests— claude-sonnet-5- In: 14
- Out: 1.7k
- Cache read: 399.9k
- Cache create: 74.2k
- Cost: ~$0.39 (est.)
- Duration: 45s
orchestrator-rollup— claude-sonnet-5- In: 6
- Out: 332
- Cache read: 182.9k
- Cache create: 16.0k
- Cost: ~$0.10 (est.)
- Duration: 9s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
gro mail draftrendered markdown bodies with CommonMark soft breaks, so a single newline became a space and a two-line sign-off (Thanks,then a name) arrived joined on one line. The renderer now uses goldmark'sWithHardWraps, so a single newline becomes<br>while a blank line still separates paragraphs. This matches how the quoted-reply path in the same command already treats newlines.TestRenderMarkdown_SingleNewlineIsALineBreakpins both halves: the sign-off keeps its line break and the blank line still yields two paragraphs. It fails on main and passes with the change;make lintis clean.