Repository navigation
fix(ci): repair public docs and update vulnerable TLS dependencies - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest main CI run at
4e089af452e4876e09d0143183b7e15992a1a56bfails in two independent gates:spawndocumentation link to the privatebackgroundmodule. Replace that link with the lifecycle explanation so public docs remain useful and build with-D warnings.rustls-webpki 0.103.15(RUSTSEC-2026-0382) andwebpki-roots 1.0.9(RUSTSEC-2026-0381). Update only those locked dependencies to patched versions0.103.16and1.0.10.Both failures were reproduced locally before the fixes. No tests, warning rules, advisory exceptions, feature gates, or CI checks changed.
Validation on reviewed head
0048c81886d6fba5f26b7bceccb7707394b1230bpassed on macOS with CI's exact Rust 1.99.1:cargo fmt --all --checkcargo check --workspace --all-targets --all-features --lockedcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --all-features --locked: 1,845 passed, zero failuresRUSTDOCFLAGS='-D warnings' cargo doc -p basis --no-default-features --no-depscargo check -p basis --no-default-features --all-targets --lockedcargo test -p basis --no-default-features --locked: 1,078 passed, zero failurescargo +1.95.0 check --workspace --all-targets --all-features --lockedThe workspace's three existing ignored entries are two subprocess helpers invoked by their parent tests and one documentation example; the no-default-feature suite has that same ignored documentation example. These remain unchanged. The full suites ran with loopback socket/process access after the sandbox blocked those operations in the initial attempt.
Only
basis/src/tools/spawn.rsandCargo.lockchanged. Linux and Windows validation is left to the PR's CI matrix.