Detector v2 - #184
Draft
LDiazN wants to merge 26 commits into
Draft
Conversation
…es computation include both ok and failing ones
…n/resolver_asn distinction in panel
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
==========================================
- Coverage 83.24% 82.36% -0.88%
==========================================
Files 89 91 +2
Lines 5788 6067 +279
==========================================
+ Hits 4818 4997 +179
- Misses 970 1070 +100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will implement the new changepoint detection algorithm highlighted on https://docs.ooni.org/data/pipeline-implementation-plan/#36-cell-state-as-a-rule-histogram
The new detector is based on the new histogram-based cell and the two-weight Bernoulli increment for the CU-SUM calculation
A new page is created for this detector panel to compare with results from the original detector
The detector runs on a fixed window rather than resuming from an old run, like the old version.
Experimenting with my local setup, we can compute a 60 days window in nearly 20 minutes