Skip to content

Fix event reporting during rebalancing and withdraw #258

Description

@nialexsan

#251
cadence/contracts/FlowALPv0.cdc
from: <-sinkVault,
poolUUID: self.uuid,
atHealth: balanceSheet.health,
amount: sinkVault.balance,
Member
@jordanschalm
jordanschalm
21 minutes ago
Should this be the actual amount withdrawn to the sink? Given the conditional on line 3806, we might for example withdraw 100X from our position, then attempt to push that 100X to the sink, but the sink only accepts 50X, so we re-deposit the remaining 50X (net withdrawal of 50X).

I think the event should reflect the net withdrawal in this case.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions