Repository navigation
perf: use dense ASCII and direct Hebrew bidi classification - #19
Merged
Merged
Conversation
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCharacterTypeprobes the largecharacterTypesmap for every character, including ASCII punctuation, numbers and Latin text, and the contiguous Hebrew alphabet. These dominate many mixed Hebrew/Latin documents.Use an immutable 128-entry array containing the existing ASCII classes and return R directly for U+05D0..U+05EA. Preserve the public
characterTypesmap and its fallback for every other input, including supplementary and invalid codepoints. This branch is independent of the supplementary Unicode, normalization, source mapping and paired-bracket changes; it targets upstreammainatebef4fbwithout prerequisites or an SDK/API change.Add exhaustive BMP comparisons, boundary/fallback checks, a mixed-text regression, a reproducible benchmark and full analysis/test CI.
Validation:
flutter analyze: no issues.dart test --reporter expanded: all 5 tests passed, including all 65,536 BMP inputs.logicalToVisual2output-list behavior.Classification batches improved in both runs; the complete-paragraph timings are noisy and do not establish a consistent end-to-end improvement. Benchmark checksums matched. No machine-dependent timing threshold is imposed.