Repository navigation
perf: route ASCII paragraph separators without property lookups - #18
Merged
xclud merged 2 commits intoNov 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paragraph scanning needs only to identify paragraph separators, but currently looks up the full bidi character type for every ASCII code unit. Recognize the five ASCII paragraph separators directly (LF, CR, U+001C..U+001E), while preserving the full Unicode table lookup for everything else.
Use the same private predicate in both BidiString.fromLogical and the deprecated splitStringToParagraphs scanner. Preserve the original codeUnits iteration, paragraph grouping, rendering behavior, and source-index APIs. CR and LF remain separate paragraph boundaries. This change is independent of the supplementary-Unicode and source-mapping proposals and is based directly on upstream main ebef4fb.
Validation:
Performance context: paired measurements on the integration fork (which already bypasses other ASCII normalization costs) showed ASCII 259-268 to 189-193 us/op, mixed text 746-748 to 710-719 us/op, and separator-heavy text 122-126 to 99-102 us/op. On the original upstream implementation, normalization dominates and end-to-end measurements were mixed; no general whole-paragraph speedup is claimed for that baseline.