Repository navigation
fix sonar findings - #1
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Streams that a failed flush or fsync left open are closed now, in the completion marker, the metadata, fstab, the interfaces file and the atomic writes of Chkroot. A stat before a rename, access checks before opens and usleep are gone, the package plan and the ipk name parsing check their bounds. The long functions are split into steps without changing what they do: the USB setup of FlashExpander and Chkroot, the image installation, the opkg run with its skip and retry loop, running a command and the flow of the wizard. The argv of the tools are built from writable buffers instead of casting away const. Paths from sysfs, /proc, the configuration and the device the user chose are marked NOSONAR with the reason, like in the Open Recovery Manager.
Like the Open Recovery Manager, agreed with atvcaptain. About and the README name it, LVGL, DejaVu Sans and Font Awesome keep their licenses. The generated license texts are left out of the SonarQube analysis like the fonts.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streams that a failed flush or fsync left open are closed now, in the
completion marker, the metadata, fstab, the interfaces file and the
atomic writes of Chkroot. A stat before a rename, access checks before
opens and usleep are gone, the package plan and the ipk name parsing check
their bounds.
The long functions are split into steps without changing what they do:
the USB setup of FlashExpander and Chkroot, the image installation, the
opkg run with its skip and retry loop, running a command and the flow of
the wizard. The argv of the tools are built from writable buffers instead
of casting away const.
Paths from sysfs, /proc, the configuration and the device the user chose
are marked NOSONAR with the reason, like in the Open Recovery Manager.