chore(ci): pin the actions and scope the token - #22
Open
LKSNDRTMLKV wants to merge 1 commit into
Open
LKSNDRTMLKV wants to merge 1 commit into
LKSNDRTMLKV wants to merge 1 commit into
Conversation
Deploying odal-node-docs with
|
| Latest commit: |
84cbcf2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05d8a130.odal-node-docs.pages.dev |
| Branch Preview URL: | https://chore-pin-and-scope-the-work.odal-node-docs.pages.dev |
Deploying odal-node-landing with
|
| Latest commit: |
84cbcf2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cdd4e2ca.odal-node-landing.pages.dev |
| Branch Preview URL: | https://chore-pin-and-scope-the-work.odal-node-landing.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P4/P5/P6 of the check-coverage audit, applied here. Small and mechanical.
Found by
tools/check-ci-parity.sh, which reports CI drift across therepositories — this repo came back with two unpinned actions and no
permissions:block.What changed
actions/checkoutandactions/setup-nodeare SHA-pinned. A tag is amutable label; a SHA is not. Both were resolved from the actions' own
repositories rather than copied from elsewhere, because a SHA pin proves
immutability, not provenance — the platform does not check that a pinned
SHA belongs to the repository named beside it, and a SHA from a fork resolves
just as happily.
permissions: contents: readat the top. There was no block at all, soevery job inherited the repository default token scope. Nothing in this
workflow writes — it checks out, installs, builds, and runs the link, leakage
and OpenAPI checks.
concurrencywithcancel-in-progress, excludingmain. A rebase or afollow-up push currently leaves the superseded run going to completion.
mainis excluded deliberately: the post-merge run is the record for that commit.
What did not change
The triggers were already right —
push: [main]plus an unfilteredpull_request— which is worth noting, because the sibling Rust repo hadpush: ["**"]alongsidepull_requestand was running every suite twice. Thisrepo did not have that bug.
No job logic, no dependency, no build step touched.
Verification
YAML parses;
permissionsandconcurrencypresent. The build itself isunchanged, so CI on this PR is the check.