Skip to content

fix(hertzbeat): improve JWT configuration and startup initialization - #86

Merged
frf12 merged 1 commit into
masterfrom
fix/hertzbeat-jwt-secret
Oct 29, 2026
Merged

frf12 merged 1 commit into
masterfrom
fix/hertzbeat-jwt-secret

Conversation

@frf12

@frf12 frf12 commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Summary

Make JWT configuration and startup initialization consistent across the HertzBeat application and deployment examples.

Solution Description

  • Initialize application settings before HTTP startup and reuse persisted values across restarts.
  • Require explicit configuration for Helm and Compose examples, and update installation and upgrade instructions. Configuration changes may require users to sign in again.
  • Add startup, persistence, and deployment-template checks to Application CI.

Validation

  • Java 17 Maven reactor build and Checkstyle passed; 22 tests passed across CommonCommandLineRunnerTest and AccountControllerTest.
  • Helm rendering tests passed on 3.16.4 and 4.3.1. Compose tests passed, including 12 config renders across four examples.
  • git diff --check passed. Full OceanBase-backed integration tests and live deployment were not run locally.

@frf12 frf12 changed the title fix(hertzbeat): eliminate public JWT signing defaults fix(hertzbeat): improve JWT configuration and startup initialization Oct 29, 2026

@hidb4ai hidb4ai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frf12
frf12 merged commit a628a05 into master Oct 29, 2026
8 checks passed
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


rongfeng.frf seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants