Repository navigation
Conversation
Large diffs (react-dom, typescript) spend 40-70s of CPU in libnpmdiff's synchronous jsdiff calls. They exceeded maxDuration, were killed before cacheLife ran, and so were recomputed on every request, while also blocking the event loop for concurrent requests. libnpmdiff now runs in a worker thread that is terminated after 40s. The timeout is returned as a "timeout" result and cached, rendered as "diff too large" on the page and as a 504 from the API. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xk9y1TZXZcrUoUrCUaLGKp
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fluid Active CPU spiked Sep 30 – Oct 9 with only a few hundred invocations per day (~17s CPU/invocation). Measured locally (prod build):
libnpmdiff calls jsdiff's
createTwoFilesPatchsynchronously per file, so huge bundled files block the event loop. Diffs overmaxDuration(60s) are killed beforecacheLiferuns, so they're recomputed on every request, and they starve concurrent requests (Bundlephobia/Packagephobia/source lookups time out).What
libnpmdiffruns in aworker_threadsWorker (new Worker(new URL("./libnpmdiff.worker.ts", import.meta.url))), terminated after 40s.{ kind: "timeout" }and cached (cacheLife("days"), notmax, in case the timeout was a slow registry download).npm diffcommand; API returns 504.Verified locally (
next build+next start)[worker thread]-src_lib_npmDiff_libnpmdiff_worker_ts_*.jschunk.Not verified
/typescript@5.8.3...typescript@5.9.2should show "too large" after ~40s and instantly on reload.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xk9y1TZXZcrUoUrCUaLGKp