upgrade: bump mina - #2447
Conversation
e5a01eb to
8d9022b
Compare
5dfb688 to
3f6119b
Compare
|
I don't have a nix setup, so if someone does have one, it would be nice if they could go format that |
|
uhhh.... I think I did it? the weirdest thing - bumping nodejs to 22 actually fixed a lot of the wasm problems we were having? how strange |
ff2d353 to
f22e24a
Compare
|
Continuing conversation here: |
|
#1885 Looks like last time node was bumped (in breaking fashion) was here, investigating This also works on node 21.7.3, bisecting further, also works on node 21.0.0 |
9674e48 to
e675578
Compare
e675578 to
5a4c740
Compare
5a4c740 to
1f78fb4
Compare
|
updated this branch to target |
Shigoto-dev19
left a comment
Shigoto-dev19
left a comment
There was a problem hiding this comment.
Lgtm! Just left a comment about the change adding ~signature_kind in local-ledger.ml
| let ledger = l##.value in | ||
| let application_result = | ||
| Transaction_logic.apply_zkapp_command_unchecked | ||
| Transaction_logic.apply_zkapp_command_unchecked ~signature_kind |
There was a problem hiding this comment.
This change seems different that what the PR is addressing.
Could you add more details about it in the PR description?
There was a problem hiding this comment.
this is due to a change in the mina repo I'd imagine
There was a problem hiding this comment.
Correct, api change
3 participants
upgrade: bumping mina (after a long time) to
compatible (8f958aac99f53f27ce34e62861775d7117821a2c)downgrades dune to 3.1 to be compatible
upgrades node to 22.0 for wasm support (across our CI)
nix rust toolchain upgrade to 2024-09-05
fixes API incompatibilities
adds
.gitattributesto some improper filesfixes our
dunefiles to have more standard flag usage (for betterinheritance)
adds a dependency debug line to a dune invocation in order to give
better tracing for objects when building (doesn't affect happy path)
Status: expected to work as soon as CI finishes
this is the root of a trunk.
children: #2502