Repository navigation
refactor(model): remove campus.webauth.models shim - #985
Merged
Merged
Conversation
Follow-up to #984: campus-api-python#120 flipped the SDK's json_client to campus.model, so the temporary compatibility shim at campus.webauth.models has no importers left (grep gate: zero hits — in-repo, SDK main, downstream heads). - delete campus/webauth/models/ - drop models from campus/webauth/__init__.py (__all__ + import) - advance campus-api-python lock 14ef22c -> 695992d (#120 merge) in the same change: the contract suite is the integration gate proving the flipped SDK resolves campus.model.HttpHeader against shim-free campus Completes the campus-model remigration acceptance: campus.model.HttpHeader / HttpAuthProperty / HttpHeaderWithAuth importable, campus.webauth.models gone. Refs #982 #970
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of the coordination plan on #982 (parent: #970) — follow-up to #984, unblocked by campus-api-python#120 (merged, SDK main
695992d).What
campus/webauth/models/— the temporary re-export shim from refactor(model): remigrate webauth models into campus.model #984. Its only consumer (the SDK's json_client) now importsfrom campus.model import HttpHeader.modelsfromcampus/webauth/__init__.py(__all__+ package import).campus-api-pythonlock14ef22c→695992din the same change — required, or the locked SDK (still importing the old path) would break auth/api/audit boots on the weekly autodeploy. This makes the contract suite the integration gate: it runs the flipped SDK against shim-free campus.Grep gate (zero
webauth.modelsimporters)campus/model/http.py(not an import; kept intentionally).695992d): zerowebauthreferences.Verification (worktree venv with SDK force-reinstalled to
695992d)ruff check .: greencampus.webauth.models→ ModuleNotFoundError;campus.webauthno longer re-exports it;json_client.HttpHeader is campus.model.HttpHeader; all packages import.Acceptance (#982)
campus.model.HttpHeader/HttpAuthProperty/HttpHeaderWithAuthimportable;campus.webauth.modelsgone; model boundary unchanged ({common}-only).After merge: downstream relocks (classroom / admin / profile-dev / cli) bump campus-suite + campus-api-python together per repo — #982 closes once those land.
Refs #982 #970