Repository navigation
refactor: import HttpHeader from campus.model - #120
Merged
Merged
Conversation
campus#982 remigrated the webauth header models back into campus.model (campus.model.http, re-exported via campus.model); campus.webauth.models remains only as a temporary compatibility shim on campus weekly. Flip json_client to the canonical path and relock campus-suite to the weekly commit carrying the new path (56ee636). Coordinated with campus#982: after this merges, campus deletes the shim and downstream consumers relock both campus-suite and campus-api-python together. Refs nyjc-computing/campus#982
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of the coordination plan on nyjc-computing/campus#982 (parent: nyjc-computing/campus#970, phase 3 prep).
campus PR nyjc-computing/campus#984 remigrated the webauth header models (
HttpAuthProperty/HttpHeader/HttpHeaderWithAuth) intocampus.model(campus/model/http.py, re-exported viacampus.model), restoring the pre-extractioncampus.model.HttpHeaderAPI.campus.webauth.modelsremains on weekly only as a temporary compatibility shim serving this repo.What
campus_python/json_client/__init__.py:from campus.webauth.models import HttpHeader→from campus.model import HttpHeader(same class object — the shim re-exports identities, so no behavior change).poetry lock: campus-suite relocked50e69c9→56ee636(the #984 merge commit, carrying the new path). Required in the same PR or CI would fail to import.Verification
poetry installfrom the new lock (campus-suite @ 56ee636) + pytest: 321 passed locally in a worktree — the exact CI configuration.json_client.HttpHeader is campus.model.HttpHeader.After this merges (per #982 plan)
campus.webauth.modelsshim + advance campus'scampus-api-pythonlock in the same PR (grep gate: zerowebauth.modelsimporters).Refs nyjc-computing/campus#982