Repository navigation
feat(audit): expose journey_id filter in Traces.search() - #111
Merged
Merged
Conversation
The audit server's /traces/search honours a journey_id query param (login-journey tag, campus#803, shipped in campus#812), but the Python client did not carry it, so library consumers could not filter by journey. Add the keyword-only journey_id filter to Traces.search(), passed through as a query value exactly like the other optional filters (omitted when None), documented in the docstring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #110.
What
Traces.search()gains a keyword-onlyjourney_id: str | None = Nonefilter, passed through as thejourney_idquery value exactly like the other optional filters (omitted from the query whenNone), and documented in the docstring.Why
The audit server's search route honours
journey_id— the login-journey tag from campus#803, shipped in campus#812 (merged toweekly) — but the Python client did not carry it, so library consumers could not filter by journey. This also unblocks the--journeyflag forcampus audit traces search(campus-cli#54), which was deliberately omitted until the library supported it.Verification
test_search_sends_journey_id_when_givenasserts the query param reaches the client; the pre-existing exact-dict assertion intest_search_gets_leaf_route_with_filterscovers omission when not given.Acceptance checklist (#110)
Traces.search(journey_id=...)sendsjourney_idas a query parameter; omitted when not given.--journeyflag — separate repo, follow-up there.