Repository navigation
fix: landing page CTA respects auth state (closes #15) - #18
Merged
Merged
Conversation
index.html hardcoded the Sign In CTAs, so a signed-in user landing on / saw "Sign In to Get Started" in the hero (and "Sign In Now" at the bottom) while the navbar already showed their identity. Branch both CTAs on g.user: signed in -> Go to Dashboard (/dashboard), signed out -> current Sign In CTAs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
index.htmlhardcoded the Sign In CTAs, so a signed-in user landing on/saw "Sign In to Get Started" in the hero — and "Sign In Now" in the bottom CTA section — whilebase.html's navbar already showed their identity. Both sections now branch ong.user(same idiom the navbar uses):/dashboard) in the hero; bottom section becomes "Welcome Back / Go to your dashboard…" with the same buttonVerification (local, real dev login session)
GET /: Sign In CTAs only, no "Go to Dashboard".GET /(live login session in the Flask session): hero and bottom both render "Go to Dashboard" →/dashboard; "Sign In to Get Started" and "Sign In Now" are gone from the page.