Repository navigation
Conversation
Assisted by AI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
govulncheckworkflows fail on master, V6.2 and V5.4 since 2026-11-05, on two advisories forgithub.com/labstack/echo/v4:X-Real-IPheader set by the callerX-Forwarded-ForheaderEcho#IPExtractor(http/engine.go), the workaround named in both advisories.http/ratelimiter.go) has one shared limit and ignores the caller's IP.govulncheck has no option to skip a finding (v1.9.0 can write OpenVEX, not read it).
Change
.vex/nuts-node.openvex.json: an OpenVEX document with anot_affectedstatement for each of the two advisories, with the reason..github/scripts/govulncheck-vex.sh: reads govulncheck's JSON output and the VEX document. It fails on every vulnerability that is called by the code, unless anot_affectedstatement covers it.timestamp(orlast_updated). After that the check fails on it again, until someone reviews the statement and updates the date. OpenVEX has no expiry field, so this rule is in the script.govulncheck.yaml,govulncheck-cron-schedule.yaml): the action writes JSON to a file, and the script decides whether the job fails.docs/pages/deployment/docker.rst): new section "Scanning images for vulnerabilities". Operators can pass the same document to their image scanner.Adding a statement to the VEX document is a public claim that the node is not affected. Each one needs an analysis like the one above.
Testing
Script, on govulncheck's JSON output for master (Go 1.27.3):
MAX_AGE_DAYS=0(statements too old)VEX document with Trivy, on
nutsfoundation/nuts-node:6.2.19(echo v4.16.1): without--vexboth echo CVEs are reported; with--vexthey are listed as suppressed (not_affected) and the other findings are unchanged.make docs-docker: build succeeds, no new warnings.Not tested: the changed workflows themselves.
govulncheck.yamlonly runs on push to master and release branches, and the scheduled workflow checks out those branches, which don't have the script yet.After merging
net/http, fixed in Go 1.27.4 and 1.26.11) is a real finding.go.modon master says 1.27.3.nuts-node/v5.Assisted by AI