Repository navigation
Conversation
…er on the proxy Assisted by AI
reinkrul
requested review from
Dirklectisch,
JorisHeadease,
gerardsn,
stevenvegt and
woutslakhorst
as code owners
November 17, 2026 12:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The deployment docs only said the node reads
X-Forwarded-For"when logging calls" and to check the proxy's documentation. They didn't say what the client IP is used for, how the header is read, or that the proxy has to overwrite it.This came up while checking whether the node is affected by GO-2026-6875 and GO-2026-6872 (echo): it isn't, because the node always sets echo's
IPExtractorand its rate limiter doesn't identify callers. The docs now answer the question "is the client IP used for anything security-related?".Change
docs/pages/deployment/recommended-deployment.rst:X-Forwarded-Forand other headers (http.clientipheader).No code changes.
Note for reviewers
"Not used to allow, deny or rate-limit requests" is true today (
audit/http.go,http/requestlogger.go,http/tokenV2/middleware.go,network/transport/grpc/ip_interceptor.go; the rate limiter inhttp/ratelimiter.goignores the caller). If that changes, this section has to change with it.Testing
make docs-docker: build succeeds, no new warnings.Backport
The file is the same on V6.2. Backport branch is prepared; PR follows after review.
Assisted by AI