Repository navigation
Conversation
lforchini
force-pushed
the
immutable-data-scaling-engine
branch
from
October 30, 2026 10:55
7547ebb to
5ac1df8
Compare
lforchini
force-pushed
the
immutable-data-scaling-engine
branch
from
October 30, 2026 11:22
5ac1df8 to
395ca81
Compare
lforchini
force-pushed
the
immutable-data-scaling-engine
branch
from
October 30, 2026 11:43
395ca81 to
498e87a
Compare
lforchini
force-pushed
the
immutable-data-scaling-engine
branch
from
November 5, 2026 15:03
498e87a to
0398141
Compare
lforchini
force-pushed
the
immutable-data-scaling-engine
branch
from
November 5, 2026 15:10
0398141 to
5a6a530
Compare
lforchini
marked this pull request as ready for review
November 5, 2026 15:10
tmakatos
reviewed
Nov 6, 2026
tmakatos
left a comment
tmakatos
left a comment
Collaborator
There was a problem hiding this comment.
There's a lot of unrelated changes here.
| const BACKEND_NAME: &str = "fake"; | ||
|
|
||
| fn build_fake_backend(dir: &Path) -> Result<Box<dyn Backend>, BackendClientError> { | ||
| fn build_fake_backend(dir: &PrefixedPath) -> Result<Box<dyn Backend>, BackendClientError> { |
Collaborator
There was a problem hiding this comment.
The PrefixedPath changes are unrelated.
|
|
||
| /// Immutable, controller-processed input for one engine evaluation. | ||
| #[derive(Debug, Default, Clone)] | ||
| pub struct EngineInstanceSnapshot { |
Collaborator
There was a problem hiding this comment.
Why not just InstanceSnapshot?
| impl InstanceState { | ||
| /// Create lifecycle state for the exact controller instance. | ||
| fn new(instance: Arc<Instance>) -> Self { | ||
| /// Create lifecycle state for one controller-owned instance. |
Collaborator
Author
|
Oh, this one should still be a draft, sorry about that |
lforchini
marked this pull request as draft
November 6, 2026 09:05
lforchini
force-pushed
the
immutable-data-scaling-engine
branch
from
November 6, 2026 10:24
5a6a530 to
6c0dc53
Compare
lforchini
force-pushed
the
immutable-data-scaling-engine
branch
5 times, most recently
from
November 11, 2026 11:49
3487a88 to
5f83de4
Compare
The controller constructs a struct from tracking mutable state and backend collected performance counters which it then passes to the engine. Previously the engine was given a reference to the Instance itself, potentially allowing the engine to bypass the controller. Now, only the controller can command the Instance with the engine advising the controller. This split also makes testing easier. Instead of having to construct full Instances, now only fake data needs to be passed to the engine to evaluate its decisions. AI-Generated: most of it Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
lforchini
force-pushed
the
immutable-data-scaling-engine
branch
from
November 11, 2026 14:27
5f83de4 to
9d75264
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller constructs a struct from tracking mutable state and
backend collected performance counters which it then passes to the
engine. Previously the engine was given a reference to the Instance
itself, potentially allowing the engine to bypass the controller. Now,
only the controller can command the Instance with the engine advising
the controller.
This split also makes testing easier. Instead of having to construct
full Instances, now only fake data needs to be passed to the engine to
evaluate its decisions.
AI-Generated: most of it
Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬