Repository navigation
fix(image): rebuild on Go 1.26.10 and patched Alpine packages - #7
Merged
Merged
Conversation
The published image embeds a binary built with Go 1.23 and old golang.org/x modules, and ships Alpine packages with released fixes. A Trivy scan reports CVE-2025-68121 (CVSS 10.0) in the Go standard library plus openssl, musl and zlib findings. - Build with golang:1.26.10-alpine and GOTOOLCHAIN=local so the embedded stdlib is the pinned one. - Bump golang.org/x/net to v0.62.0 (and x/sys, x/term, x/text). - Run apk upgrade in the runtime stage. - go 1.26 vets printf calls during go test; replace three non-constant format strings so the test build passes. Trivy (vuln scanner) on the rebuilt image reports zero findings.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version to 1.26, upgrades several dependencies, and optimizes Dockerfile builds and package dependencies. It also refactors string formatting and error creation in internal/report and pkg/popeye.go. Feedback suggests avoiding unnecessary string allocations in internal/report/writer.go by passing arguments separately to fmt.Fprint, and adding nil checks in pkg/popeye.go to prevent potential nil-pointer dereferences when accessing output file flags.
RamanKharchee
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The published popeye image embeds a binary built with Go 1.23, which carries CVE-2025-68121 (CVSS 10.0) in the standard library, plus Alpine packages that already have fixes. This rebuilds it on Go 1.26.10 with current
golang.org/xmodules and patched Alpine packages. Popeye's output is unchanged.How to verify
v0.11.1-nudgebee.2tag sorelease.ymlpublishes the image.trivy image ghcr.io/nudgebee/popeye:v0.11.1-nudgebee.2reports no vulnerabilities (the currentv0.11.1-nudgebee.1reports a 10.0).popeye -A -o json --force-exit-zeroagainst any cluster returns the same report as the previous image.Type of change
Test plan and detail
golang:1.26.10-alpinebuilder withGOTOOLCHAIN=local;golang.org/x/netv0.38.0 -> v0.62.0 (plus x/sys, x/term, x/text).k8s.io/*untouched.go test, so three non-constant format strings are replaced; output is the same.go build ./...,go vet ./...,go test ./...pass on Go 1.26.10.Local e2e: ran the old and new images with the scanner's exact args (
-A -o json --force-exit-zero) against a local kind cluster -> both exit 0; JSON has the same 410 key paths and the same content (score 90, grade A, 22 sections, 250 issue keys).Trivy (vuln) on the rebuilt image: 0 findings at any severity. Old image: 1 NVD 8.0+ (stdlib 10.0), 10 counting vendor scores.