[nudgebee-dev]

Description

In Client.Run (pkg/ws/client.go:122), transient WebSocket disconnections and session terminations are logged at Error level using c.logger.Error("websocket session ended", "err", err). Because Client.Run automatically handles disconnections through an exponential backoff reconnection loop, transient connection drops and relay restarts are expected recoverable events rather than fatal application errors. Logging them at Error severity causes false-positive alerts in monitoring systems (such as container_log_messages_total{level="error"}).

This change modifies the log level from Error to Warn (c.logger.Warn("websocket session ended", "err", err)), accurately representing the transient nature of the event while keeping visibility into disconnect cycles. A unit test in pkg/ws verifies that disconnections emit Warn logs and auto-reconnect successfully without producing Error logs.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Enhancement (non-breaking change which improves existing functionality)
• Refactor (non-breaking change which improves code structure)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation
• CI/CD

Original Error/Logs

Click to expand the original error that triggered this fix

In Client.Run, change the log level of 'websocket session ended' from Error to Warn (c.logger.Warn("websocket session ended", "err", err)) when connectAndServe returns an error, as the client handles transient disconnections through its automatic exponential backoff reconnection loop. Verify with unit tests in pkg/ws that disconnections log at Warn level and auto-reconnect successfully without emitting Error logs.

Files located during the investigation: pkg/ws/client.go

The investigation already read this code:
**Code examined**

- `pkg/ws/client.go`:120-123 — Reconnection loop logs any non-nil error from connectAndServe at Error level

err := c.connectAndServe(ctx)
if err != nil {
c.logger.Error("websocket session ended", "err", err)
}

- `pkg/ws/client.go`:270-275 — readLoop ignores normal closure codes (1000 and 1001) but wraps all other connection terminations as errors

if err != nil {
if websocket.IsCloseError(err, websocket.CloseNormalClosure, websocket.CloseGoingAway) {
return nil
}
return fmt.Errorf("read error: %w", err)
}

How Has This Been Tested?

• Unit tests
• Manual testing

Checklist

• CLA signed (the CLA bot will prompt on your first PR)
• make validate passes (fmt + lint + test)
• Docs updated if the wire shape, config surface, or proxy module behavior changed

---

🤖 This PR was automatically generated by NudgeBee AI coding agent

Powered by AI-driven code analysis and automated fix generation

🔍 View Original Investigation

Click the link above to see the full investigation and analysis that led to this fix

View Detailed Nubi Conversation

---

✅ Verification

Build verification passed for the affected modules.

Commands run

PASSED (cd . && go build ./...) exit=0

[nudgebee-dev]

Nudgebee Automated Followup

Fixed lint errors in pkg/ws/client_test.go by using a tagged switch on slog.Record level (QF1003), ignoring close error in deferred conn.Close() (errcheck), and properly checking the error returned from runErrCh (errcheck / S1005). Amended the single bot commit and pushed to origin using --force-with-lease.

Commit: 7caf76180c33

[nudgebee-dev]

Nudgebee Automated Followup

Resolved the CI govulncheck vulnerability failure (GO-2026-6809 in crypto/x509@go1.26.9) by bumping the Go version directive in go.mod to 1.26.10. Verified that go test ./... passes, amended the bot commit, and pushed the updated commit to origin with --force-with-lease.

Commit: d5195a670797