Repository navigation
Conversation
Tab-completion for ls/explain/fund/rebuild/update used installedDeep() without spreading npm.flatOptions, so loadActual() imported .npm-extension even when ignore-scripts/ignore-extension was set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tab-completion for
ls,explain,fund,rebuild, andupdatecallsinstalledDeep(), which built Arborist withoutnpm.flatOptions.loadActual()then imported a project-root.npm-extensioneven whenignore-scripts/ignore-extensionwas set.This spreads
...npm.flatOptionsinto both Arborist constructors (same aslsexec) and forcesignoreExtension: truebecause completion is read-only name inventory.Tests
node . test test/lib/utils/installed-deep.jsdoes not execute .npm-extension during completion inventorylib/utils/installed-deep.jscoverage 100%Notes
installedDeep()withignoreExtension: trueinflatOptionsstill executed.npm-extension.mjsbefore this change.