Repository navigation
Conversation
Invalid color names and duplicate arguments previously shared a generic syntax diagnostic, making the underlying mistake difficult to identify.
pkondzior
force-pushed
the
notable-trait-color
branch
from
October 30, 2026 23:15
ac6328d to
9b435f3
Compare
notriddle
force-pushed
the
notable-trait-color
branch
from
October 31, 2026 23:02
ba790b3 to
ff0d714
Compare
notriddle
approved these changes
Oct 31, 2026
Owner
There was a problem hiding this comment.
These improvements are definitely worthwhile. Thanks a bunch!
Once rust-lang#160370 is merged, we'll see about getting this merged in, too.
Owner
|
Okay, it's merged. Can you rebase this, open it against rust-lang/rust, and |
Author
|
@notriddle done rust-lang#165298 should I close this one ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid color names and duplicate arguments previously shared a generic syntax diagnostic, making the underlying mistake difficult to identify.
Addresses rust-lang#164728