Skip to content

build: sync rustc version warning - #66794

Open
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:codex/align-rustc-minimum
Open

inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:codex/align-rustc-minimum

Conversation

@inoway46

@inoway46 inoway46 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Raise the rustc warning threshold to 1.88 to match BUILDING.md and deps/crates/Cargo.toml.

rust-version = "1.88"

Refs: #65912 (comment)

Raise the rustc warning threshold to 1.88 to match BUILDING.md and
deps/crates/Cargo.toml. Keep the cargo threshold at 1.86.

Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 16, 2026
@inoway46
inoway46 marked this pull request as ready for review October 16, 2026 15:51
@legendecas legendecas added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 16, 2026
@legendecas

Copy link
Copy Markdown
Member

Mirroring dont-land labels as #65742.

@legendecas legendecas added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 17, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 18, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
   ✖  No Jenkins CI runs detected

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
�[36m⠋�[39m Loading data for nodejs/node/pull/66794
�[36m⠋�[39m Loading data for nodejs/node/pull/66794
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66794
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66794
�[36m⠋�[39m Getting comments from nodejs/node/pull/66794
�[36m⠋�[39m Getting commits from nodejs/node/pull/66794
✔  Done loading data for nodejs/node/pull/66794
----------------------------------- PR info ------------------------------------
Title      build: sync rustc version warning (#66794)
   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
Branch     inoway46:codex/align-rustc-minimum -> nodejs:main
Labels     build, author ready, needs-ci, commit-queue, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v26.x
Commits    1
 - build: align rustc version warning with minimum requirement
Committers 1
 - inoway46 <inoueyuya416@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66794
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66794
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 16 Oct 2026 15:45:09 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/66794#pullrequestreview-5550624570
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/66794#pullrequestreview-5550973379
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/66794#pullrequestreview-5551493854
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@inoway46 inoway46 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants