Repository navigation
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
added
lts-watch-v22.x
nodejs-github-bot
added
build
legendecas
reviewed
Oct 16, 2026
| o['variables']['node_use_quic'] = b(options.experimental_quic and | ||
| not options.without_ssl) | ||
| if options.experimental_quic and options.without_ssl: | ||
| warn('--experimental-quic is incompatible with --without-ssl') |
Member
There was a problem hiding this comment.
Suggested change
| warn('--experimental-quic is incompatible with --without-ssl') | |
| error('--experimental-quic is incompatible with --without-ssl') |
The src/quic depends on crypto sources like crypto/crypto_context.h, ncrypto.h and ngtcp2_crypto_ossl.h. This should be an error.
Contributor
Author
There was a problem hiding this comment.
If I take your suggestion in https://github.com/nodejs/node/pull/66754/changes#r4295324904, this can stay a warning, correct?
legendecas
reviewed
Oct 16, 2026
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We emit similar errors for other configure flags, QUIC is the odd one out where errors are silently swallowed. Those should be turned into errors, but that can be a follow up that we won't backport, while this one should be safe to backport.