Repository navigation
Conversation
Store prefix counts in section records to avoid a separate vector and its allocations during multi-globstar matching. Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66716 +/- ##
=======================================
Coverage 90.48% 90.48%
=======================================
Files 791 791
Lines 277204 277210 +6
Branches 53309 53317 +8
=======================================
+ Hits 250827 250833 +6
- Misses 16789 16805 +16
+ Partials 9588 9572 -16
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Oct 14, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store non-globstar prefix counts in section records instead of a separate vector, avoiding its allocations during multi-globstar matching. Matching bounds use the same counts; matching behavior and recursion limits are unchanged. Add regression coverage and benchmarks for multi-globstar matching and in-memory path filtering.
Measured against ea6ec93 on Apple M2, macOS arm64, Node v27.0.0-pre, V8 15.5.35.22-node.15.
Filtering throughput changes below include unadjusted 95% confidence-interval half-widths. Reverse runs swap baseline and candidate labels.
**/node_modules/**/test/****/src/****/node_modules/**/test/****/src/**The 16 multi-globstar hit/miss microbenchmarks improve 18.73-37.88% in the forward comparison, with every gain confirmed in reverse.
Across 30 configurations, each direction used 30 independent samples per binary: 3,600 samples total. All 20 targeted gains remain significant after Holm correction in both directions; neither direction shows a corrected-significant regression.