Skip to content

build: add --shared-highway configure flag - #65686

Open
aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:shared-hwy
Open

build: add --shared-highway configure flag#65686
aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:shared-hwy

Conversation

@aduh95

@aduh95 aduh95 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

V8 supports it, we might as well

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Aug 31, 2026
@github-actions

This comment was marked as outdated.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (761e49e) to head (e0693ab).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65686      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.02%     
==========================================
  Files         769      769              
  Lines      261316   261316              
  Branches    49625    49626       +1     
==========================================
- Hits       235367   235337      -30     
- Misses      16996    17031      +35     
+ Partials     8953     8948       -5     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95
aduh95 requested a review from legendecas September 3, 2026 11:50
Comment thread tools/v8_gypfiles/v8.gyp Outdated
@github-actions

This comment was marked as outdated.

1 similar comment
@github-actions

This comment was marked as outdated.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions

This comment was marked as outdated.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 488 -> 489 => +1 1 / 489 = 0.2%
aarch64-linux 489 -> 490 => +1 1 / 490 = 0.2%
x86_64-darwin 428 -> 429 => +1 1 / 429 = 0.2%
aarch64-darwin 431 -> 432 => +1 1 / 432 = 0.2%
Total 1836 -> 1840 => +4 4 / 1840 = 0.2%
Changelog
@@ -617,0 +618,4 @@
+/nix/store/9ps8zgr1ayyb0xsfjgc5l4fj5cl6580l-libhwy-1.3.0 (x86_64-darwin)
+/nix/store/mv5xsa097plw3k09r541c31xg0ma9r6i-libhwy-1.4.0 (aarch64-darwin)
+/nix/store/l71xwd2dvawcswgpi64pmpvki33fm8bh-libhwy-1.4.0 (aarch64-linux)
+/nix/store/y7llycqq0c2g83bir7sbqc2970lzl9vp-libhwy-1.4.0 (x86_64-linux)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants