module: derive builtinModules from enabled builtin set - #65418
Open
sjungwon03 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03
force-pushed
the
refactor/module-builtin-exposure
branch
from
August 20, 2026 08:31
614500e to
79ffed7
Compare
Contributor
Author
|
Follow-up: the focused test assumed that
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module.builtinModulesis expected to contain only builtins accessibleto user code.
During pre-execution, each experimental flag determines whether its
builtin is added to
BuiltinModule's user-requirable set viaBuiltinModule.allowRequireByUsers().Before this change,
getAllBuiltinModuleIds()added every scheme-onlybuiltin to the
Module.builtinModulescandidate list, includingexperimental builtins that had not been added to the user-requirable
set.
initializeCJS()then repeated the flag checks and removednode:dtls,node:quic,node:ffi, andnode:vfs.Derive the scheme-only portion of
Module.builtinModulesfrom thealready-established user-requirable set instead. This keeps the list
consistent with the existing
require('node:...')access policy andremoves the duplicated filtering in
initializeCJS().Existing scheme-only builtins such as
node:test,node:sea, andnode:sqliteremain listed.Add coverage for
Module.builtinModulesandrequire('node:...')with and without each experimental flag.
Refs: #56185
Refs: #56870
Refs: #63158